Re: [Possible Breakage] t1308 - Bad return value from test-tool
- Date: Fri, 8 Feb 2019 23:24:04 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [Possible Breakage] t1308 - Bad return value from test-tool
On Fri, Feb 08, 2019 at 04:42:19PM -0500, Randall S. Becker wrote:
> t1308 has me perplexed - this is an old breakage on the NonStop platform,
> that I have just gotten around to checking with the new bash version we
> have. When running sub-test 23, the following was reported:
> Value not found for "foo.bar"
> test_expect_code: command exited with 1, we wanted 2 test-tool config
> configset_get_value foo.bar a-directory
> However, when I looked inside t/helper/test-config.c, every path reporting
> "Value not found" has a goto exit1 not exit2. It seems, from the code, that
> the test is actually incorrect and should be expecting 1 not 2, and that it
> is working properly on NonStop (but the test fails as a result).
We're expecting it to report an error reading the directory, not "value
not found". Which would yield code 2.
It sounds like you might need to set FREAD_READS_DIRECTORIES in your