Re: [PATCH 0/1] git-p4: remove ticket expiration test
- Date: Thu, 7 Feb 2019 13:45:18 +0100 (STD)
- From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
- Subject: Re: [PATCH 0/1] git-p4: remove ticket expiration test
On Wed, 6 Feb 2019, Luke Diamand wrote:
> As per thread here, this removes the git-p4 ticket expiration
> test, since it isn't really that useful.
Thank you for the prompt patch!
However, like Gábor, my feeling is that we would want that test case in a
non-flakey form, if possible. If you think that that is only possible with
a mocked p4, so be it, let's remove the test case (because the mocked one
will likely look quite a bit different). But if there are easier ways to
work around the timing issues (such as dropping the first `sync`), then
I'd prefer to have the safety of a regression test.
> Luke Diamand (1):
> git-p4: remove ticket expiry test
> t/t9833-errors.sh | 27 ---------------------------
> 1 file changed, 27 deletions(-)