Web lists-archives.com

Re: [PATCH v6 2/2] config: allow giving separate author and committer idents




On Wed, Feb 06, 2019 at 10:28:34AM +0100, Ævar Arnfjörð Bjarmason wrote:
> 
> William, is that something you're intererested in carrying forward? I
> can also help if you want. Sorry your first contribution to git has
> turned into this mess of re-rolls, as often happens we find that when
> trying to tweak something that the existing behavior doesn't have any
> tests.
 
 I'm open to it, but since we aren't sure about reverting the patch I
 guess we should wait for Jeff to reply?

> I think it's worth spending a bit more time here to prove to ourselves
> that the changes aren't e.g. spamming users with the ident advice in
> cases where we don't want that, but maybe everyone else is tired of this
> and we should just take your v5 and fix the other stuff later. I'll
> leave that up to you / Junio to decide.

Junio,

I guess it's up to you, should we take my v5 patch then do the other
fixes later?

William