Web lists-archives.com

Re: [PATCH v3 1/1] config: allow giving separate author and committer idents




Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

>> I do not recall we crossed the bridge to allow trailing comma here
>> at the end of enum definition.
>
> In advice.c:
>
> 	enum color_advice {
> 		ADVICE_COLOR_RESET = 0,
> 		ADVICE_COLOR_HINT = 1,
> 	};
>
> In builtin/pack-objects.c:
>
> 	enum missing_action {
> 		MA_ERROR = 0,      /* fail if any missing objects are encountered */
> 		MA_ALLOW_ANY,      /* silently allow ALL missing objects */
> 		MA_ALLOW_PROMISOR, /* silently allow all missing PROMISOR objects */
> 	};
>
> In builtin/rev-list.c:
>
> 	enum missing_action {
> 		MA_ERROR = 0,    /* fail if any missing objects are encountered */
> 		MA_ALLOW_ANY,    /* silently allow ALL missing objects */
> 		MA_PRINT,        /* print ALL missing objects in special section */
> 		MA_ALLOW_PROMISOR, /* silently allow all missing PROMISOR objects */
> 	};
>
> ... and I will stop here. You are correct that the majority of our enums
> does not let its last item end in a comma. But we did cross that bridge.

Good.  Thanks for eyeballing.

I do not think any of these can be compiled out on a platform with a
picker compiler, and the one in rev-list.c is from late 2017, so it
probably be a safe assumption that nobody would mind the trailing
comma.