Web lists-archives.com

Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet

SZEDER Gábor <szeder.dev@xxxxxxxxx> writes:

> Before installing the necessary dependencies, our OSX build jobs run
> 'brew update --quiet'.  This is problematic for two reasons:
>   - This '--quiet' flag apparently broke overnight, resulting in
>     errored builds:
> ...
>     I belive that this breakage will be noticed and fixed soon-ish, so
>     we could probably just wait a bit for this issue to solve itself,

Yuck.  Well, an external influence that can break the automated
build job overnight should be capable of fixing it overnight ;-)

>     but:
>   - 'brew update --quiet' wasn't really quiet in the first place, as
>     it listed over about 2000 lines worth of available packages that
>     we absolutely don't care about, see e.g. one of the latest
>     'master' builds:
>       https://travis-ci.org/git/git/jobs/486134962#L113
> So drop this '--quiet' option and redirect 'brew update's standard
> output to /dev/null to make it really quiet, thereby making the OSX
> builds work again despite the above mentioned breakage.

Sounds good.

>     There is no conflict with Dscho's Azure Pipelines patch series; the
>     patch contexts overlap a bit, but the auto-merging results look good
>     to me.

Thanks for extra careful.

If this is truly urgent, I could merge this to 'maint' and merge the
result upwards to 'pu' and it would hide the issue on my four
integration branches.  But one thing that makes me wonder is if we
can (or want to) do anything to help other people who test build
with pull requests.  I guess they need to rebase on top of whatever
commit that has this fix?  That sounds more like a tail wagging a
dog, though.  I dunno.

>  ci/install-dependencies.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 06c3546e1e..5968efdbbe 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -34,7 +34,7 @@ linux-clang|linux-gcc)
>  	popd
>  	;;
>  osx-clang|osx-gcc)
> -	brew update --quiet
> +	brew update >/dev/null
>  	# Uncomment this if you want to run perf tests:
>  	# brew install gnu-time
>  	brew install git-lfs gettext