Web lists-archives.com

Re: [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn




Jeremy Huddleston Sequoia <jeremyhu@xxxxxxxxx> writes:

> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@xxxxxxxxx>
> ---
>  t/test-lib.sh | 3 +++
>  1 file changed, 3 insertions(+)

This obviously won't be acceptable as-is to my tree.  Shouldn't this
be something to be dealt with in config.mak.uname or something that
is meant to define platform-specific customization?

>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 0f1faa24b2..4060a53f56 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1017,6 +1017,9 @@ fi
>  
>  GITPERLLIB="$GIT_BUILD_DIR"/perl/build/lib
>  export GITPERLLIB
> +PERL_VERSION=$(grep DEFAULT /usr/local/versioner/perl/versions | sed 's:^.*= *\([^ ]*\)$:\1:')
> +PERL5LIB="$GIT_BUILD_DIR"/perl:"$(xcode-select -p)"/Library/Perl/$PERL_VERSION
> +export PERL5LIB
>  test -d "$GIT_BUILD_DIR"/templates/blt || {
>  	error "You haven't built things yet, have you?"
>  }