Web lists-archives.com

Re: tt/bisect-in-c, was Re: What's cooking in git.git (Jan 2019, #04; Mon, 28)




Hi Junio,

On Tue, 29 Jan 2019, Johannes Schindelin wrote:

> On Mon, 28 Jan 2019, Junio C Hamano wrote:
> 
> > * tt/bisect-in-c (2019-01-02) 7 commits
> >  - bisect--helper: `bisect_start` shell function partially in C
> >  - bisect--helper: `get_terms` & `bisect_terms` shell function in C
> >  - bisect--helper: `bisect_next_check` shell function in C
> >  - bisect--helper: `check_and_set_terms` shell function in C
> >  - wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()
> >  - bisect--helper: `bisect_write` shell function in C
> >  - bisect--helper: `bisect_reset` shell function in C
> > 
> >  More code in "git bisect" has been rewritten in C.
> > 
> >  Comments?
> 
> Just to make sure you know: both Chris and I reviewed the patches before
> Tanushree sent them off...

Oh, and I just realized that there are 4 merge conflicts with `master`,
all of them related to `the_repository` changes. So they should be easy
enough to resolve, even if I still think that it is a bad use of
maintainer's time, and asking contributors *not* to rebase projects too
much of distrust in contributors' skills in my mind.

So I suggested to Tanushree to ask you whether you prefer this not to be
rebased.

Ciao,
Dscho