Web lists-archives.com

sparse job, was Re: [PATCH] test-xml-encode: fix sparse NULL pointer warnings




Hi Ramsay,

On Sat, 26 Jan 2019, Ramsay Jones wrote:

> 
> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
> Hi Johannes,
> 
> If you need to re-roll your 'js/vsts-ci' branch, could you please
> squash this into the relevant patch (commit af7747e7c7 ("tests: optionally
> write results as JUnit-style .xml", 2019-01-23)).

Certainly!

BTW would you be interested in working with me on an Azure Pipeline that
runs `sparse` on all of Junio's branches? (I am now pretty proficient with
building a software package in one Azure Pipeline, publishing it as a
build artifact, then consuming it from another Azure Pipeline, so I would
build the `sparse` package as an Ubuntu package and offer it as a build
artifact.)

I seem to recall that you once explained to me what it takes, but that
mail vanished from my inbox and I cannot find it.

Thanks,
Dscho

> 
> Thanks!
> 
> ATB,
> Ramsay Jones
> 
>  t/helper/test-xml-encode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/t/helper/test-xml-encode.c b/t/helper/test-xml-encode.c
> index 367c4875e6..a648bbd961 100644
> --- a/t/helper/test-xml-encode.c
> +++ b/t/helper/test-xml-encode.c
> @@ -26,7 +26,7 @@ int cmd__xml_encode(int argc, const char **argv)
>  		if (tmp2) {
>  			if ((ch & 0xc0) != 0x80) {
>  				fputs(utf8_replace_character, stdout);
> -				tmp2 = 0;
> +				tmp2 = NULL;
>  				cur--;
>  				continue;
>  			}
> @@ -34,7 +34,7 @@ int cmd__xml_encode(int argc, const char **argv)
>  			tmp2++;
>  			if (--remaining == 0) {
>  				fwrite(tmp, tmp2 - tmp, 1, stdout);
> -				tmp2 = 0;
> +				tmp2 = NULL;
>  			}
>  			continue;
>  		}
> -- 
> 2.20.0
>