Web lists-archives.com

[PATCH 0/9] drop some unused parameters




I've mentioned before that I have a series which compiles cleanly with
-Wunused-parameters. I split this work roughly into three groups:

  1. Patches that fix bugs (i.e., we should have been using the
     parameter but didn't).

  2. Patches that drop unused parameters (i.e., code cleanup).

  3. Patches that annotate undroppable parameters (e.g., ones that are
     present due to a callback interface).

All of the patches from group 1 have been merged already. So this series
starts us off on group 2. There are about 50 patches in that group.
Given that none of them are urgent, I plan to feed them in batches to
avoid overwhelming reviewers. I'm also ordering them to avoid conflicts
with other topics in flight (this batch has no conflicts with 'next',
and only one minor textual conflict with 'pu').

The patches themselves are pretty much independent from each other. I
based these on master. They're cleanup which _could_ go to maint, and I
suspect they'd apply there, too (most of these are pretty old), but
again, I don't think there's a particular urgency to this.

  [1/8]: match-trees: drop unused path parameter from score functions
  [2/8]: apply: drop unused "def" parameter from find_name_gnu()
  [3/8]: create_bundle(): drop unused "header" parameter
  [4/8]: column: drop unused "opts" parameter in item_length()
  [5/8]: show_date_relative(): drop unused "tz" parameter
  [6/8]: config: drop unused parameter from maybe_remove_section()
  [7/8]: convert: drop len parameter from conversion checks
  [8/8]: convert: drop path parameter from actual conversion functions

 apply.c              |  5 ++---
 builtin/bundle.c     |  3 +--
 bundle.c             |  4 ++--
 bundle.h             |  4 ++--
 cache.h              |  2 +-
 column.c             |  4 ++--
 config.c             |  3 +--
 convert.c            | 28 ++++++++++++++--------------
 date.c               |  8 ++++----
 match-trees.c        | 16 +++++++---------
 t/helper/test-date.c |  2 +-
 11 files changed, 37 insertions(+), 42 deletions(-)