Re: [PATCH] upload-pack: teach deepen-relative in protocol v2
- Date: Thu, 10 Jan 2019 14:54:30 -0800
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH] upload-pack: teach deepen-relative in protocol v2
Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes:
>> > This, when applied on top of ecbdaf08991, seems to break t5702.30,
>> > at least for me.
>> > Tip of 'pu' in today's push-out will be broken as it has this patch
>> > merged.
>> > Can somebody take a look?
>> I can reproduce this. I'll investigate this further. In the meantime,
>> feel free to remove this from pu.
> The test failure is caused by a bug I fixed in . I've verified that
> if I apply  first, then this, all tests pass. If you do include this
> patch in some branch, it should be dependent on , but I understand if
> you'd like reviewers to look at both this and  first.
> I thought I tested this without something that fixes the issue fixed by
>  and it passed, but apparently that's not true.
>  https://public-inbox.org/git/20190110193645.34080-1-jonathantanmy@xxxxxxxxxx/
OK, that means that it would be the cleanest to make them into
two-patch series, I guess.
Let's requeue these two and see what happens.