Web lists-archives.com

Re: [PATCH] log: add %S option (like --source) to log --format




On Thu, Jan 3, 2019 at 6:33 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> issac.trotts@xxxxxxxxx writes:
>
> > From: Issac Trotts <issac.trotts@xxxxxxxxx>
>
> I think you want to have
>
>         From: Issac Trotts <issactrotts@xxxxxxxxxx>
>
> instead, so that the authorship actually matches your sign-off.

Makes sense. I'll do that.

>
> > -     if (source) {
> > +     if (source || (rev->pretty_given && (rev->commit_format == CMIT_FMT_USERFORMAT) && w.source)) {
>
> I am not sure why the above is not simply
>
>         if (source || w.source) {
>
> but needs to check pretty-given etc.  Care to explain why?

Good idea. Your simplified version passes all the tests.