Re: [PATCH 1/3] Add 'human' date format
- Date: Sun, 6 Jan 2019 01:19:36 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 1/3] Add 'human' date format
On Fri, Jan 04, 2019 at 06:03:18AM -0700, Stephen P Smith wrote:
> On Friday, January 4, 2019 12:50:35 AM MST Jeff King wrote:
> > On Thu, Jan 03, 2019 at 06:19:56AM -0700, Stephen P. Smith wrote:
> > >
> > > I didn't see anything in the code which would prohibit setting something
> > > like that.
> > Yeah, I don't think supporting that is too hard. I was thinking
> > something like this:
> I take it that if I update Linus's patch, I still keep Junio's and Linus'
> sign-off line for the purpose of the chain of custody? Of should I use a
> second patch?
I think the most interesting question is the actual authorship (i.e.,
the "From:" field). I think people are generally OK with having their
patches polished a bit to fix obvious bugs or short-comings. But at some
point if you make too many changes they or may not want to have the
result attributed to them. ;)
For the particular change I suggested, it's borderline to me on whether
it hits that case, so I'd probably err on the side of caution. And I'd
either expect Linus to say "yeah, that sounds like a good direction", or
I'd do it as a separate patch. And if a separate patch, I'd probably
tease Linus's patch out into two separate ones: one to add "human", and
one to implement "auto". And then drop the "auto" one in favor of your
new patch (with you as the author).
And I think that makes the signoff questions go away for this instance
(keep the signoffs for Linus's, and just signoff the new patch
yourself). But here's some general pontificating in that direction:
Normally you can just drop Junio's signoff. The chain of custody is
usually "author, then maintainer" and he'll re-add his maintainer
signoff when he picks up your patch. In this case of this patch it's
"author, then polisher, then maintainer", but Junio is still at the
Now one can argue that Junio picked up Linus's patch, which you then
picked up from Junio's repository and fed back to Junio. But you
could just as well have picked Linus's patch up from the mailing
list and then polished it. So I don't know that having Junio twice
in the chain is really that interesting.
Generally, yes, I'd keep Linus's signoff in a situation like this.
He is asserting that the original work done meets the DCO
requirements. You polishing the patch does not change that (of
course you could introduce a bunch of new code that doesn't meet the
DCO and sign it off anyway, but that's why there's ordering in the
chain of custody. Somebody investigating would probably walk
backwards up the chain).