Web lists-archives.com

Re: [PATCH] doc: remove unneeded TODO for release_commit_memory




On Tue, Jan 1, 2019 at 7:02 AM Albert Burt <aburthinds@xxxxxxxxx> wrote:
>
> The code that was merged with commit 1102405 left in an TODO that

People usually use something this to produce the commit reference

    git show -s --date=short --pretty='format:%h (%s - %ad)'

which produces

110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)

> is no longer relevant. It seems as if we can remove this todo.
> util seems to not be a field of the struct commit,
> definition of struct commit --> commit.c:27
> The commit list also, does not contain a field for util.

There was commit->util, which was deleted in 9d2c97016f (commit.h:
delete 'util' field in struct commit - 2018-05-19). You can mention it
too if you reroll this patch.

> ____
> By making a contribution to this project, I certify that:
>
> a. The contribution was created in whole or in part by me and I
>    have the right to submit it under the open source license
>    indicated in the file; or
>
> b. The contribution is based upon previous work that, to the best
>    of my knowledge, is covered under an appropriate open source
>    license and I have the right under that license to submit that
>    work with modifications, whether created in whole or in part
>    by me, under the same open source license (unless I am
>    permitted to submit under a different license), as indicated
>    in the file; or
>
> c. The contribution was provided directly to me by some other
>    person who certified (a), (b) or (c) and I have not modified
>    it.
>
> d. I understand and agree that this project and the contribution
>    are public and that a record of the contribution (including all
>    personal information I submit with it, including my sign-off) is
>    maintained indefinitely and may be redistributed consistent with
>    this project or the open source license(s) involved.
> ____

I think you can drop this. Your S-o-b below implies all this.

> Signed-off-by: Albert Burt <aburthinds@xxxxxxxxx>
> ---
>  commit.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/commit.c b/commit.c
> index 2d94e0b199..2ff6dca0bc 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
>         c->index = 0;
>         free_commit_buffer(c);
>         free_commit_list(c->parents);
> -       /* TODO: what about commit->util? */
> -

Obviously correct :)

>         c->object.parsed = 0;
>  }
>
> --
> 2.17.2 (Apple Git-113)
>


-- 
Duy