Re: [PATCH v3 2/4] config.mak.uname: support for modern HPE NonStop config.
- Date: Fri, 28 Dec 2018 14:42:50 -0500
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH v3 2/4] config.mak.uname: support for modern HPE NonStop config.
On Thu, Dec 27, 2018 at 5:39 PM <randall.s.becker@xxxxxxxxxx> wrote:
> A number of configuration options are not automatically detected by
> configure mechanisms, including the location of Perl and Python.
> There was a problem at a specific set of operating system versions
> that caused getopt to have compile errors. Account for this by
> providing emulation defines for those versions.
This version of the patch looks much better and addresses my comments
on previous attempts. One note below...
> Signed-off-by: Randall S. Becker <rsbecker@xxxxxxxxxxxxx>
> diff --git a/config.mak.uname b/config.mak.uname
> @@ -441,26 +441,45 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
> + # The current /usr/coreutils/rm at lowest support level does not work
> + # with the git test structure. Long paths cause nftw as in
> + # 'trash directory...' cause rm to terminate prematurely without fully
> + # removing the directory at OS releases J06.21 and L17.02.
> + # Default to the older rm until those two releases are deprecated.
> + RM = /bin/rm -f
Thanks, this comment does a much better job of explaining the actual
problem and selling the solution.
There is a slight grammatical problem:
Long paths _cause_ ... _cause_ rm to terminate...
which might deserve fixing.