RE: [PATCH v1 0/4] HPE NonStop Port Commits
- Date: Thu, 27 Dec 2018 11:01:31 -0500
- From: "Randall S. Becker" <rsbecker@xxxxxxxxxxxxx>
- Subject: RE: [PATCH v1 0/4] HPE NonStop Port Commits
On December 27, 2018 7:13, Derrick Stolee:
> On 12/26/2018 6:05 PM, randall.s.becker@xxxxxxxxxx wrote:
> > From: "Randall S. Becker" <rsbecker@xxxxxxxxxxxxx>
> > This set of patches is a distilled version of the minimal set of
> > changes to git that will allow it to run as client and server on HPE
> > NonStop NSE and NSX systems. NSR systems are no longer under support
> > so references to them have been removed. Each patch in this set is
> > independent but required for correctness.
> > Randall S. Becker (4):
> > transport-helper: use xread instead of read
> > config.mak.uname: support for modern HPE NonStop config.
> > git-compat-util.h: add FLOSS headers for HPE NonStop
> > compat/regex/regcomp.c: define intptr_t and uintptr_t on NonStop
> These patches look correct to me. Just one question on patch 3
> (git-compat-util.h: add FLOSS headers for HPE NonStop).
> I'm not able to comment on patch 2 (config.mak.uname: support for modern
> HPE NonStop config.), but it looks to be wrapped in a platform-specific 'if',
> so should be fine if you are happy with it.
Thanks! Please go for it, with v2 3/4 that should be available now. This will radically simplify our life on maintaining the port.
Randall et. Cohorts who know who they are.