RE: [PATCH v1 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop
- Date: Thu, 27 Dec 2018 10:55:01 -0500
- From: "Randall S. Becker" <rsbecker@xxxxxxxxxxxxx>
- Subject: RE: [PATCH v1 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop
On December 27, 2018 7:10, Derrick Stolee wrote:
> On 12/26/2018 6:05 PM, randall.s.becker@xxxxxxxxxx wrote:
> > The NSIG define is also not defined on __TANDEM, so we define it here
> > as 100 if it is not defined only for __TANDEM builds.
> > +#if ! defined NSIG
> Why didn't you use "#ifndef" here?
> Taking a look at the file, I see both "#ifdef" and "#if defined" but no "#if !
I'm good with revising as follows and removing the irrelevant lines (stay tuned):
+/* NonStop NSE and NSX do not provide NSIG. SIGGUARDIAN(99) is the highest
+ known, by detective work using kill -l as a list is all signals
+ instead of signal.h where it should be. */
+# define NSIG 100