Re: [PATCH 4/4] git-status.txt: render tables correctly under Asciidoctor
- Date: Sun, 16 Dec 2018 05:59:45 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 4/4] git-status.txt: render tables correctly under Asciidoctor
On Sat, Dec 15, 2018 at 12:27:42PM +0100, Martin Ågren wrote:
> Asciidoctor removes the indentation of each line in these tables, so the
> last lines of each table have a completely broken alignment.
> Similar to 379805051d ("Documentation: render revisions correctly under
> Asciidoctor", 2018-05-06), use an explicit literal block to indicate
> that we want to keep the leading whitespace in the tables.
> Because this gives us some extra indentation, we can remove the one that
> we have been carrying explicitly. That is, drop the first four spaces of
> indentation on each line. With Asciidoc (8.6.10), this results in
> identical rendering before and after this commit, both for git-status.1
> and git-status.html.
Yep, this makes sense based on the prior art you cited.
The whole series looks good to me. Thanks for working on it!