Re: [PATCH 2/3] sha1-file: emit error if an alternate looks like a repository
- Date: Wed, 05 Dec 2018 12:35:08 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH 2/3] sha1-file: emit error if an alternate looks like a repository
Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
> Since 26125f6b9b ("detect broken alternates.", 2006-02-22) we've
> emitted an error if the alternates directory doesn't exist, but not
> for the common misstep of adding a path to another git repository as
> an alternate, as opposed to its "objects" directory.
> Let's check for this, i.e. whether X/objects or X/.git/objects exists
> if the user supplies X and print an error (which as a commit leading
> up to this one shows doesn't change the exit code, just "warns").
I agree that "Let's check for this" is a good idea, but do not
necessarily agree with "i.e.". Don't we have a helper that takes
the path to an existing directory and answers "Yup, it does look
like a Git repository"? Using that is a lot more in line with what
you claimed to do in the title for this patch.
I haven't read 3/3 yet, but as I said, I suspect it is reasonable to
DWIM and use the object store associated with the directory we found
to be a repository.