Re: [PATCH 3/9] submodule.c: sort changed_submodule_names before searching it
- Date: Tue, 4 Dec 2018 16:12:46 -0800
- From: Jonathan Tan <jonathantanmy@xxxxxxxxxx>
- Subject: Re: [PATCH 3/9] submodule.c: sort changed_submodule_names before searching it
> We can string_list_insert() to maintain sorted-ness of the
> list as we find new items, or we can string_list_append() to
> build an unsorted list and sort it at the end just once.
> As we do not rely on the sortedness while building the
> list, we pick the "append and sort at the end" as it
> has better worst case execution times.
I would write this entire commit message as:
Instead of using unsorted_string_list_lookup(), sort
changed_submodule_names before performing any lookups so that we can
use the faster string_list_lookup() instead.
The code in this patch is fine, and patches 1-2 are fine too.