Re: [PATCH] rebase docs: fix incorrect format of the section Behavioral Differences
- Date: Tue, 4 Dec 2018 13:24:11 -0800
- From: Elijah Newren <newren@xxxxxxxxx>
- Subject: Re: [PATCH] rebase docs: fix incorrect format of the section Behavioral Differences
On Mon, 3 Dec 2018, Johannes Sixt wrote:
> The text body of section Behavioral Differences is typeset as code,
> but should be regular text. Remove the indentation to achieve that.
> While here, prettify the language:
> - use "the x backend" instead of "x-based rebase";
> - use present tense instead of future tense;
> and use subsections instead of a list.
> Signed-off-by: Johannes Sixt <j6t@xxxxxxxx>
> Cf. https://git-scm.com/docs/git-rebase#_behavioral_differences
> I actually did not test the result, because I don't have the
> The sentence "The am backend sometimes does not" is not very useful,
> but is not my fault ;) It would be great if it could be made more
> specific, but I do not know the details.
That sentence is my fault. I've been sitting on a patch for about a
week that fixes it which I was going to submit after 2.20.0, but since
you're fixing this text up right now, I guess putting these two patches
together makes sense. I've rebased it on top of your commit and provided
-- 8< --
Subject: [PATCH] git-rebase.txt: update note about directory rename detection
In commit 6aba117d5cf7 ("am: avoid directory rename detection when
calling recursive merge machinery", 2018-08-29), the git-rebase manpage
probably should have also been updated to note the stronger
incompatibility between git-am and directory rename detection. Update
Signed-off-by: Elijah Newren <newren@xxxxxxxxx>
Documentation/git-rebase.txt | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
index 41631df6e4..b220b8b2b6 100644
@@ -569,8 +569,12 @@ it to keep commits that started empty.
Directory rename detection
-The merge and interactive backends work fine with
-directory rename detection. The am backend sometimes does not.
+The merge and interactive backends work fine with directory rename
+detection. The am backend sometimes does not because it operates on
+"fake ancestors" that involve trees containing only the files modified
+in the patch. Without accurate tree information, directory rename
+detection cannot safely operate and is thus turned off in the am