Re: [PATCH] sideband: color lines with keyword only
- Date: Mon, 3 Dec 2018 15:42:57 -0800
- From: Jonathan Nieder <jrnieder@xxxxxxxxx>
- Subject: Re: [PATCH] sideband: color lines with keyword only
Stefan Beller wrote:
> On Mon, Dec 3, 2018 at 3:23 PM Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
>> I was curious about what versions of Gerrit this is designed to
>> support (or in other words whether it's a bug fix or a feature).
>> Looking at examples like , it seems that Gerrit historically always
>> used "ERROR:" so the 59a255aef0 logic would work for it. More
>> recently,  (ReceiveCommits: add a "SUCCESS" marker for successful
>> change updates, 2018-08-21) put SUCCESS on a line of its own. That
>> puts this squarely in the new-feature category.
> Ooops. From the internal bug, I assumed this to be long standing Gerrit
> behavior, which is why I sent it out in -rc to begin with.
No worries. Can't hurt for Junio to have a few patches to apply to
"pu" or "next" to practice using the release candidates. :)
>> In the old code, we would escape early if 'n == len', but we didn't
>> need to. If 'n == len', then
>> src[len] == '\0'
> src[len] could also be one of "\n\r", see the caller
> recv_sideband for sidebase case 2.
Yes, I noticed too late[*]. Sorry for the noise.
The patch still looks good.