[PATCH 0/5] Add a new "sparse" tree walk algorithm
- Date: Wed, 28 Nov 2018 13:52:41 -0800 (PST)
- From: "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx>
- Subject: [PATCH 0/5] Add a new "sparse" tree walk algorithm
One of the biggest remaining pain points for users of very large
repositories is the time it takes to run 'git push'. We inspected some slow
pushes by our developers and found that the "Enumerating Objects" phase of a
push was very slow. This is unsurprising, because this is why reachability
bitmaps exist. However, reachability bitmaps are not available to us because
of the single pack-file requirement. The bitmap approach is intended for
servers anyway, and clients have a much different behavior pattern.
Specifically, clients are normally pushing a very small number of objects
compared to the entire working directory. A typical user changes only a
small cone of the working directory, so let's use that to our benefit.
Create a new "sparse" mode for 'git pack-objects' that uses the paths that
introduce new objects to direct our search into the reachable trees. By
collecting trees at each path, we can then recurse into a path only when
there are uninteresting and interesting trees at that path. This gains a
significant performance boost for small topics while presenting a
possibility of packing extra objects.
The main algorithm change is in patch 4, but is set up a little bit in
patches 1 and 2.
As demonstrated in the included test script, we see that the existing
algorithm can send extra objects due to the way we specify the "frontier".
But we can send even more objects if a user copies objects from one folder
to another. I say "copy" because a rename would (usually) change the
original folder and trigger a walk into that path, discovering the objects.
In order to benefit from this approach, the user can opt-in using the
pack.useSparse config setting. This setting can be overridden using the
Derrick Stolee (5):
revision: add mark_tree_uninteresting_sparse
list-objects: consume sparse tree walk
pack-objects: add --sparse option
revision: implement sparse algorithm
pack-objects: create pack.useSparse setting
Documentation/git-pack-objects.txt | 9 +-
bisect.c | 2 +-
builtin/pack-objects.c | 9 +-
builtin/rev-list.c | 2 +-
http-push.c | 2 +-
list-objects.c | 51 ++++++++++-
list-objects.h | 4 +-
revision.c | 113 +++++++++++++++++++++++
revision.h | 2 +
t/t5322-pack-objects-sparse.sh | 139 +++++++++++++++++++++++++++++
10 files changed, 323 insertions(+), 10 deletions(-)
create mode 100755 t/t5322-pack-objects-sparse.sh
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-89/derrickstolee/push/sparse-v1