Re: [PATCH v1 1/2] log -G: Ignore binary files
- Date: Tue, 27 Nov 2018 09:51:34 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH v1 1/2] log -G: Ignore binary files
Stefan Beller <sbeller@xxxxxxxxxx> writes:
> On Wed, Nov 21, 2018 at 1:08 PM Thomas Braun
> <thomas.braun@xxxxxxxxxxxxxxxxxxx> wrote:
>> The -G <regex> option of log looks for the differences whose patch text
>> contains added/removed lines that match regex.
>> The concept of differences only makes sense for text files, therefore
>> we need to ignore binary files when searching with -G <regex> as well.
> What about partial text/partial binary files?
Good point. You'd use "-a" (or "--text") to tell the diff machinery
to treat the contents as text, and the new logic must pay attention
to that command line option.