Re: t5570 shaky for anyone ?
- Date: Mon, 26 Nov 2018 11:45:38 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: t5570 shaky for anyone ?
On Sun, Nov 25, 2018 at 11:22:47PM +0100, SZEDER Gábor wrote:
> > The following fixes it, but I am not sure if this is the ideal
> > solution.
> Currently this is the only test that looks at 'daemon.log', but if we
> ever going to add another one, then that will be prone to the same
> I wonder whether it's really that useful to have the daemon log in the
> test script's output... if the log was sent directly to daemon log,
> then the window for this race would be smaller, but still not
> completely closed.
> Anyway, I added Peff to Cc, since he added that whole fifo-shell-loop
Yeah, see my comments on the other part of the thread. If we did write
directly to a file, I think that would be enough here because git-daemon
writes this entry before running the sub-process. So by the time
ls-remote finishes, we know that it talked to upload-pack, and we know
that before upload-pack was run, git-daemon wrote the log entry. That
assumes git-daemon doesn't buffer its logs (but if it does, we should
probably fix that).