Re: pathspec: problems with too long command line
- Date: Wed, 21 Nov 2018 22:37:49 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: pathspec: problems with too long command line
Jeff King <peff@xxxxxxxx> writes:
> On Wed, Nov 21, 2018 at 10:23:34AM +0100, Marc Strapetz wrote:
>> From our GUI client we are invoking git operations on a possibly large set
>> of files. ...
>> command line length, especially on Windows  and OSX . To workaround
>> this problem we are currently splitting up such operations by invoking
>> multiple git commands. This works well for some commands (like add), but
>> doesn't work well for others (like commit).
> Quite a few commands take --stdin, which can be used to send pathspecs
> (and often other stuff) without size limits. I don't think either
> "commit" or "add" does, but that might be another route.
A GUI client, like your server, should not be using end-user facing
Porcelain commands like "add" and "commit" anyway. In the standard
"update-index" followed by "write-tree" followed-by "commit-tree"
followed by "update-ref" sequence, the only thing that needs to take
pathspec is the update-index step, and it already does take --stdin.
In any case, I share your gut feeling that this should not be a
magic pathspec, but should instead be "--stdin[-paths]", for command
line parsing's sanity. Catchng random strings that begin with
double dash as fishy is much simpler and more robust than having to
tell if a string that is a risky or a benign magic pathspec.