Re: [PATCH] test-lib-functions: make 'test_cmp_rev' more informative on failure
- Date: Tue, 20 Nov 2018 06:37:29 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] test-lib-functions: make 'test_cmp_rev' more informative on failure
On Tue, Nov 20, 2018 at 12:25:38PM +0100, SZEDER Gábor wrote:
> > but we do not
> > usually bother to do so for our helper functions (like test_cmp).
> test_i18ngrep() does since your 03aa3783f2 (t: send verbose
> test-helper output to fd 4, 2018-02-22).
Oh, indeed. Usually I find myself forgetting about patches I worked on
from 5 years ago. Forgetting about one from 9 months ago is a new low.
> > I don't think it would ever hurt,
> > though. Should we be doing that for all the others, too?
> I think we should, and you agreed:
> but then went travelling, and then the whole thing got forgotten.
Stupid vacation. :)
OK, yes, I reaffirm my agreement that this is the right direction, then.
Sorry for my lack of memory.