Re: [PATCH/RFC v1 1/1] Use size_t instead of unsigned long
- Date: Mon, 19 Nov 2018 08:40:10 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH/RFC v1 1/1] Use size_t instead of unsigned long
Derrick Stolee <stolee@xxxxxxxxx> writes:
>> This needs to go on top of pu, to cover all the good stuff
>> cooking here.
> Better to work on top of 'master', as the work in 'pu' will be
> rewritten several times, probably.
We may not be able to find any good moment to update some codepaths
with deep callchains that reaches a basic API function that take
ulong that way, as things are always in motion, but hopefully a lot
of areas that need changes are rather isolated.
For example, the changes I see around "offset" (which is "ulong" and
the patch wants to change it to "size_t") in archive-tar.c in the
patch do not have any interaction with the changes in this patch
outside that single file, and I do not think any topic in-flight
would interact with this change badly, either. I didn't carefully
look at the remainder of the patches, but I have a feeling that many
can be separated out into independent and focused set of smaller
patches that can be evaluated on their own.