Web lists-archives.com

Re: [PATCH v2] read-cache: write all indexes with the same permissions




Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:

> Do you mean that you don't agree that following should always create
> both "foo" and e.g. ".git/refs/heads/master" with the same 644
> (-rw-rw-r--) mode:
>
>     (
>         rm -rf /tmp/repo &&
>         umask 022 &&
>         git init /tmp/repo &&
>         cd /tmp/repo &&
>         echo hi >foo &&
>         git add foo &&
>         git commit -m"first"
>     )
>
> To me what we should do with the standard umask and what
> core.sharedRepository are for are completely different things.

Ahh, of course.  If you put it that way, I do agree that it gives us
a valid use case where core.sharedRepository is false and the umask
of repository owner is set to 022 (or anything that does not allow
write to group or others, and allows read to group) to let group
members only peek but not touch the contents of the repository.

I think I was distracted by the mention of ore.sharedRepository in
the proposed log message.