Re: [PATCH v2] read-cache: write all indexes with the same permissions
- Date: Sat, 17 Nov 2018 17:57:18 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH v2] read-cache: write all indexes with the same permissions
Christian Couder <christian.couder@xxxxxxxxx> writes:
>> > +test_expect_success POSIXPERM 'same mode for index & split index' '
>> > + git init same-mode &&
>> > + (
>> > + cd same-mode &&
>> > + test_commit A &&
>> > + test_modebits .git/index >index_mode &&
>> > + test_must_fail git config core.sharedRepository &&
>> > + git -c core.splitIndex=true status &&
>> > + shared=$(ls .git/sharedindex.*) &&
>> I think the command substitution and 'ls' are unnecessary, and
>> would work as well.
> If there is no shared index file with the above we would get:
> $ echo $shared
> which seems bug prone to me.
It is not bug *PRONE*, but is already wrong, as the way this
variable is used is
+ case "$shared" in
+ *" "*)
+ # we have more than one???
+ false ;;
+ test_modebits "$shared" >split_index_mode &&
+ test_cmp index_mode split_index_mode ;;
i.e. we'd think there is a singleton ".git/shared/index.*" and we
can feed it to test_modebits.
So what you wrote originally is corrrect.