Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h
- Date: Wed, 14 Nov 2018 12:32:29 +0700
- From: Danh Doan <congdanhqx@xxxxxxxxx>
- Subject: Re: [PATCH] git-compat-util: prefer poll.h to sys/poll.h
"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes:
>> - t1308.23 is failing because musl `fopen` is success when open directory
>> in readonly mode. POSIX allows this behavior:
>> The named file is a directory and mode requires write access.
> Does setting FREAD_READS_DIRECTORIES fix this?
Yes, setting FREAD_READS_DIRECTORIES fixes this.
And, `configure` can set that itself.
I blindly followed the Void's build template which explicitly unset it
in the configure script without investigating it.
I'll send them a patch to fix this downstream.
> brian m. carlson: Houston, Texas, US
> OpenPGP: https://keybase.io/bk2204