Re: [PATCH 1/1] bundle: refuse to create empty bundle
- Date: Tue, 13 Nov 2018 21:37:18 +0100
- From: Gaël Lhez <gael.lhez@xxxxxxxxx>
- Subject: Re: [PATCH 1/1] bundle: refuse to create empty bundle
I don't know why I receive these message (and especially now given the
time at which I pushed this) but I suppose someone (Johannes
Schindelin ?) probably pushed back my original commit from git for
windows github to GIT git repository.
If you think "bundle: cleanup lock files on error" is better, then no
problem with me. I'm not a native english speaker and I simply
expressed the reason for my problem but - after reading back my commit
- neither this mail' subject and my original commit subject (see
express the core problem.
As I'm not accustomed to pushing on GIT 'git repository' , please let
me know if I have something else to do ?
(Sent back in text mode because HTML is considered SPAM or Virus by
Le mar. 13 nov. 2018 à 20:28, Stefan Beller <sbeller@xxxxxxxxxx> a écrit :
> On Tue, Nov 13, 2018 at 7:09 AM Gaël Lhez via GitGitGadget
> <gitgitgadget@xxxxxxxxx> wrote:
> > From: =?UTF-8?q?Ga=C3=ABl=20Lhez?= <gael.lhez@xxxxxxxxx>
> > When an user tries to create an empty bundle via `git bundle create
> > <bundle> <revlist>` where `<revlist>` resolves to an empty list (for
> > example, like `master..master`), the command fails and warns the user
> > about how it does not want to create empty bundle.
> > However, the `.lock` file was still open and on Windows that means
> > that it could not be deleted properly. This patch fixes that issue.
> > This closes https://github.com/git-for-windows/git/issues/790
> > Signed-off-by: Gaël Lhez <gael.lhez@xxxxxxxxx>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> The code and the commit message make sense, but by reading the subject line
> I would have expected a different commit. Maybe
> "bundle: cleanup lock files on error"