Re: [PATCH 1/1] bundle: refuse to create empty bundle
- Date: Tue, 13 Nov 2018 11:28:13 -0800
- From: Stefan Beller <sbeller@xxxxxxxxxx>
- Subject: Re: [PATCH 1/1] bundle: refuse to create empty bundle
On Tue, Nov 13, 2018 at 7:09 AM Gaël Lhez via GitGitGadget
> From: =?UTF-8?q?Ga=C3=ABl=20Lhez?= <gael.lhez@xxxxxxxxx>
> When an user tries to create an empty bundle via `git bundle create
> <bundle> <revlist>` where `<revlist>` resolves to an empty list (for
> example, like `master..master`), the command fails and warns the user
> about how it does not want to create empty bundle.
> However, the `.lock` file was still open and on Windows that means
> that it could not be deleted properly. This patch fixes that issue.
> This closes https://github.com/git-for-windows/git/issues/790
> Signed-off-by: Gaël Lhez <gael.lhez@xxxxxxxxx>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
The code and the commit message make sense, but by reading the subject line
I would have expected a different commit. Maybe
"bundle: cleanup lock files on error"