Re: [PATCH 1/1] mingw: handle absolute paths in expand_user_path()
- Date: Tue, 6 Nov 2018 19:27:06 +0100
- From: Duy Nguyen <pclouds@xxxxxxxxx>
- Subject: Re: [PATCH 1/1] mingw: handle absolute paths in expand_user_path()
On Tue, Nov 6, 2018 at 7:15 PM Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote:
> >> @@ -709,6 +710,10 @@ char *expand_user_path(const char *path, int real_home)
> >> if (path == NULL)
> >> goto return_null;
> >> +#ifdef __MINGW32__
> >> + if (path == '/')
> >> + return system_path(path + 1);
> >> +#endif
> > Hmm, this doesn't quite fit with the intended use of this
> > function! ;-) (even on windows!)
> > I haven't looked very deeply, but doesn't this affect all
> > absolute paths in the config read by git_config_pathname(),
> > along with all 'included config' files?
> > I am pretty sure that I would not want the absolute paths
> > in my config file(s) magically 'moved' depending on whether
> > git has been compiled with 'runtime prefix' support or not!
> So, I hit 'send' before finishing my thought ...
> I can't think of a non-backwards compatible way of doing
> what you want. If backward compatibility wasn't an issue,
> then we could (maybe) have used some kind of pathname prefix
> like 'system:/path/relative/to/git/executable', or somesuch.
A pseudo variable might work, like $ROOT/path/relative/to/somewhere