Re: [PATCH v1] refresh_index: remove unnecessary calls to preload_index()
- Date: Mon, 5 Nov 2018 20:44:02 +0100
- From: Duy Nguyen <pclouds@xxxxxxxxx>
- Subject: Re: [PATCH v1] refresh_index: remove unnecessary calls to preload_index()
On Mon, Nov 5, 2018 at 8:30 PM Ben Peart <peartben@xxxxxxxxx> wrote:
> From: Ben Peart <benpeart@xxxxxxxxxxxxx>
> With refresh_index() learning to utilize preload_index() to speed up its
> operation there is no longer any benefit to having the caller preload the
> index first. Remove those unneeded calls by calling read_index() instead of
> the preload variant.
> There is no measurable performance impact of this patch - the 2nd call to
> preload_index() bails out quickly but there is no reason to call it twice.
Obviously correct. It's not shown in the context lines, but there's
also a refresh_index() after read_index() in sequencer.c too.