Re: [PATCH v5 00/12] Base SHA-256 implementation
- Date: Mon, 05 Nov 2018 11:45:06 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH v5 00/12] Base SHA-256 implementation
"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes:
> This series provides a functional SHA-256 implementation and wires it
> up, along with some housekeeping patches to make it suitable for
> Changes from v4:
> * Downcase hex constants for consistency.
> * Remove needless parentheses in return statement.
> * Remove braces for single statement loops.
> * Switch to +=.
> * Add references to rationale for SHA-256.
> * Remove inclusion of "git-compat-util.h" in header.
You ended up not doing the last one, judging from the interdiff
below. I think it is OK to leave the header in.
Thanks, will replace.