Re: [PATCH] it's called read_object_file() these days
- Date: Fri, 2 Nov 2018 02:24:29 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] it's called read_object_file() these days
On Fri, Nov 02, 2018 at 03:05:03PM +0900, Junio C Hamano wrote:
> Remnant of the old name of the function still remains in comments.
> Update them all.
Yay. What's here looks obviously correct.
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
> apply.c | 2 +-
> builtin/gc.c | 2 +-
> fast-import.c | 4 ++--
> notes.c | 2 +-
> object.h | 2 +-
> sha1-file.c | 2 +-
> 6 files changed, 7 insertions(+), 7 deletions(-)
There's another mention in Documentation/technical/api-object-access.txt.
But since the entire API is undocumented, I'm not sure it matters much.
That file has been a placeholder since 2007. Maybe we should just delete
it; its existence does not seem to be guilting anyone into documenting,
and these days we'd prefer to do it in-header anyway.