Re: [PATCH v7 09/10] submodule: support reading .gitmodules when it's not in the working tree
- Date: Wed, 31 Oct 2018 15:01:12 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH v7 09/10] submodule: support reading .gitmodules when it's not in the working tree
Antonio Ospite <ao2@xxxxxx> writes:
> I see, this is also mentioned in t/README, I had overlooked that part.
> Thank you for reporting.
>> Without this fix, your new test case will fail on Windows all the time,
>> see e.g.
> Junio, what is the plan for 'ao/submodule-wo-gitmodules-checked-out'?
I did not and do not have a specific plan ;-)
If the only remaining issue in the previous round of the topic were
what you said in <20181010205645.e1529eff9099805029b1d6ef@xxxxxx>,
which you addressed in this round, and given that Stefan (who is
likely to be the person who would need to work with you if there is
any issues later found in this topic) seemed to be happy with it in
I'd say with Dscho's bug fixed, it should be ready for 'next'.
> I see it's not in next yet; do you want me to resend the whole series
> with this fixup in or would it be less overhead for you to apply it
> directly to patch 9/10 from v7 of the series?
In either way, this involves rebuilding ao/* topic and then redoing
sb/submodule-recursive-fetch-gets-the-tip topic on top, before I can
do the 'pu' with them, so I cannot promise it will happen today, but
let's see. I think I have enough material to do the fix-up locally
without any additional thing sent from you.
> P.S. I was wondering if it is worth having patchset versions mentioned
> somewhere in pu/, maybe in merge commits if not in branch names?
No, not in branch names.
The tip date published in the "What's cooking" report is taken from
the committer date but we may want to use the author date instead,
which may help (and encourage people to be careful _before_ sending
things out, to avoid doing many rerolls in a day).