Re: [PATCH] completion: use builtin completion for format-patch
- Date: Mon, 29 Oct 2018 23:50:36 -0400
- From: Denton Liu <liu.denton@xxxxxxxxx>
- Subject: Re: [PATCH] completion: use builtin completion for format-patch
On Tue, Oct 30, 2018 at 11:20:45AM +0900, Junio C Hamano wrote:
> We saw a similar change proposed and then found out it was not such
> a good idea in:
> It seems that this one loses options like --full-index, --no-prefix,
> etc. compared to the earlier effort?
In _git_send_email, we have the following lines:
__gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
... more options ...
Would it make sense to take the old `__git_format_patch_options` and
just roll them into here, then make `_git_format_patch` use
`__gitcomp_builtin format-patch`? That way, we'd be able to reap the
benefits of using `__gitcomp_builtin` where we can.