Web lists-archives.com

Re: [PATCH 08/12] remote.c: mark messages for translation




Nguyễn Thái Ngọc Duy  <pclouds@xxxxxxxxx> writes:

> @@ -995,12 +995,12 @@ static int match_explicit_lhs(struct ref *src,
>  		 * way to delete 'other' ref at the remote end.
>  		 */
>  		if (try_explicit_object_name(rs->src, match) < 0)
> -			return error("src refspec %s does not match any.", rs->src);
> +			return error(_("src refspec %s does not match any"), rs->src);
>  		if (allocated_match)
>  			*allocated_match = 1;
>  		return 0;
>  	default:
> -		return error("src refspec %s matches more than one.", rs->src);
> +		return error(_("src refspec %s matches more than one"), rs->src);
>  	}
>  }

These minor changes that are not accompanied by their own
justification mean that the patches in this series cannot blindly be
trusted, which in turn means that I won't have bandwidth to process
this series properly for now.

I also saw die() -> BUG() that was not highlighted in the proposed
log message; the single instance I happened to notice looked
sensible, but I am not sure about the others.

There are other series in flight that touch the same area of code
and in different ways, causing unnecessary conflicts, which does not
help us either X-<.