Re: [PATCH 2/3] ewok_rlw.h: add missing 'inline' to function definition
- Date: Sat, 27 Oct 2018 02:29:09 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 2/3] ewok_rlw.h: add missing 'inline' to function definition
On Sat, Oct 27, 2018 at 02:52:05AM +0100, Ramsay Jones wrote:
> The 'ewok_rlw.h' header file contains the rlw_get_run_bit() function
> definition, which is marked as 'static' but not 'inline'. At least when
> compiled by gcc, with the default -O2 optimization level, the function
> is actually inlined and leaves no static version in the ewah_bitmap.o
> and ewah_rlw.o object files. Despite this, add the missing 'inline'
> keyword to better describe the intended behaviour.
Yep, this makes sense. Thanks!