Re: [PATCH 05/10] submodule: store OIDs in changed_submodule_names
- Date: Fri, 26 Oct 2018 11:57:47 -0700
- From: Jonathan Tan <jonathantanmy@xxxxxxxxxx>
- Subject: Re: [PATCH 05/10] submodule: store OIDs in changed_submodule_names
> Reviewed-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx>
Probably better not to include such lines, especially since the review
by me is not yet complete.
Having said that, patches 1-5 look good to me. Patches 1-3 are identical
to the previous version, which I have already reviewed. In patch 4,
Stefan made the code change I suggested .
In this patch, compared to the previous version which I have already
reviewed , the code is unchanged aside from some variable renaming. I
suggested a commit title change which Stefan has done.