Web lists-archives.com

Re: [PATCH 05/10] submodule: store OIDs in changed_submodule_names




> Reviewed-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx>

Probably better not to include such lines, especially since the review
by me is not yet complete.

Having said that, patches 1-5 look good to me. Patches 1-3 are identical
to the previous version, which I have already reviewed. In patch 4,
Stefan made the code change I suggested [1].

In this patch, compared to the previous version which I have already
reviewed [2], the code is unchanged aside from some variable renaming. I
suggested a commit title change which Stefan has done.

[1] https://public-inbox.org/git/20181017212624.196598-1-jonathantanmy@xxxxxxxxxx/
[2] https://public-inbox.org/git/20181017214534.199890-1-jonathantanmy@xxxxxxxxxx/