Re: [PATCH] travis-ci: no longer use containers
- Date: Fri, 26 Oct 2018 07:06:18 +0200
- From: Sebastian Staudt <koraktor@xxxxxxxxx>
- Subject: Re: [PATCH] travis-ci: no longer use containers
Junio C Hamano <gitster@xxxxxxxxx> writes:
> Sebastian Staudt <koraktor@xxxxxxxxx> writes:
> > Travis CI will soon deprecate the container-based infrastructure
> > enabled by `sudo: false` in ce59dffb34190e780be2fa9f449f842cadee9753.
> > More info:
> > https://blog.travis-ci.com/2018-10-04-combining-linux-infrastructures
> Thanks for posting a patch that would serve as a good discussion
> starter. This is not a criticism on your patch, but more is a RFD
> to those who helped our use of Travis by contributing to .travis.yml
> and ci/.
In fact this was the intention while creating this patch. Although I see
I could have made this a bit clearer in the initial message.
Having a patch that may cause a broken build or other CI problems
seems more appropriate than waiting for Travis CI to flip the switch
and searching for the problem afterwards.
> Don't we need to do some other things so that we can run in vm
> environment, rather than in container environment, before doing this
> change? IOW, aren't we doing in .travis.yml something we can do
> only in container but not in vm (if there is any), and if so,
> shouldn't we be rewriting that something so that we can run in vm?
> I know ce59dffb ("travis-ci: explicity use container-based
> infrastructure", 2016-01-26) only added "sudo: false" without doing
> anything else (e.g. adding things that are only available to those
> who run in container), but if we added stuff that are not usable in
> vm environment after that commit since then, we need to adjust them
> so that we can migrate to the container-based environment, no?
> To me, removing that "sudo: false" line seems like the least thing
> we need to worry about. After all, they say that whether we have
> "sudo: false" or not, the CI jobs will start running in vm
> environment and not in container. So if the rest of .travis.yml is
> ready to run in vm environment, we do not have to do anything ;-).
> In short, my question to Lars and SZEDER is, are we already prepared
> to be thrown into a vm environment?
> If the answer is "yes", then I think removing "sudo: false" is
> probably still a good thing to do for documentation purposes
> (i.e. showing that we knew we are ready to go through their
> > Signed-off-by: Sebastian Staudt <koraktor@xxxxxxxxx>
> > ---
> > .travis.yml | 2 --
> > 1 file changed, 2 deletions(-)
> > diff --git a/.travis.yml b/.travis.yml
> > index 4d4e26c9df..8d2499739e 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -1,7 +1,5 @@
> > language: c
> > -sudo: false
> > -
> > cache:
> > directories:
> > - $HOME/travis-cache
> > --
> > 2.19.1