Re: [PATCH] builtin/grep.c: remote superflous submodule code
- Date: Sun, 07 Oct 2018 09:29:18 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH] builtin/grep.c: remote superflous submodule code
Stefan Beller <sbeller@xxxxxxxxxx> writes:
> In f9ee2fcdfa (grep: recurse in-process using 'struct repository',
> 2017-08-02), we introduced a call to repo_read_gitmodules in builtin/grep
> to simplify the submodule handling.
> After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules
> file, 2017-08-03) this is no longer necessary, but that commit did not
> cleanup the whole tree, but just show cased the new way how to deal with
> submodules in ls-files.
> Cleanup the only remaining caller to repo_read_gitmodules outside of
Well, submodule-config.c has its implementation and another caller,
which technically is outside submodule.c ;-) repo_read_gitmodules
has two more callers in unpack-trees.c these days, so perhaps we can
do without this last paragraph.