Re: [PATCH] builtin/grep.c: remote superflous submodule code
- Date: Sat, 6 Oct 2018 10:59:59 +0200
- From: Antonio Ospite <ao2@xxxxxx>
- Subject: Re: [PATCH] builtin/grep.c: remote superflous submodule code
On Fri, 5 Oct 2018 15:45:57 -0700
Stefan Beller <sbeller@xxxxxxxxxx> wrote:
> In f9ee2fcdfa (grep: recurse in-process using 'struct repository',
> 2017-08-02), we introduced a call to repo_read_gitmodules in builtin/grep
> to simplify the submodule handling.
> After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules
> file, 2017-08-03) this is no longer necessary, but that commit did not
> cleanup the whole tree, but just show cased the new way how to deal with
> submodules in ls-files.
> Cleanup the only remaining caller to repo_read_gitmodules outside of
> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx>
Not sure if I am entitled to formally ack it, but:
Acked-by: Antonio Ospite <ao2@xxxxxx>
> Antonio Ospite writes:
> > BTW, with Stefan Beller we also identified some unneeded code which
> > could have been removed to alleviate the issue, but that would not have
> > solved it completely; so, I am not removing the unnecessary call to
> > repo_read_gitmodules() builtin/grep.c in this series, possibly this can
> > become a stand-alone change.
> Here is the stand-alone change.
Thank you for sending it.
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?