Web lists-archives.com

Re: [PATCH v3] coccicheck: process every source file at once




On Thu, Oct 04, 2018 at 07:17:47PM -0700, Jacob Keller wrote:
> Junio, do you want me to update the commit message on my side with the
> memory concerns? Or could you update it to mention memory as a noted
> trade off.

We have been running 'make -j2 coccicheck' in the static analysis
build job on Travis CI, which worked just fine so far.  The Travis CI
build environments have 3GB of memory available [1], but, as shown in
[2], with this patch the memory consumption jumps up to about
1.3-1.8GB for each of those jobs.  So with two parallel jobs we will
very likely bump into this limit.

So this patch should definitely change that build script to run only a
single job.


1 - https://docs.travis-ci.com/user/common-build-problems/#my-build-script-is-killed-without-any-error
2 - https://public-inbox.org/git/20181003101658.GM23446@localhost/


> > >  Makefile | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index df1df9db78da..da692ece9e12 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -2715,10 +2715,8 @@ endif
> > >  %.cocci.patch: %.cocci $(COCCI_SOURCES)
> > >         @echo '    ' SPATCH $<; \
> > >         ret=0; \
> > > -       for f in $(COCCI_SOURCES); do \
> > > -               $(SPATCH) --sp-file $< $$f $(SPATCH_FLAGS) || \
> > > -                       { ret=$$?; break; }; \
> > > -       done >$@+ 2>$@.log; \
> > > +       $(SPATCH) --sp-file $< $(COCCI_SOURCES) $(SPATCH_FLAGS) >$@+ 2>$@.log; \
> > > +       ret=$$?; \
> > >         if test $$ret != 0; \
> > >         then \
> > >                 cat $@.log; \
> > > --
> > > 2.18.0.219.gaf81d287a9da
> > >