Re: [PATCH] more oideq/hasheq conversions
- Date: Tue, 2 Oct 2018 17:34:32 -0400
- From: Derrick Stolee <stolee@xxxxxxxxx>
- Subject: Re: [PATCH] more oideq/hasheq conversions
On 10/2/2018 5:19 PM, Jeff King wrote:
We added faster equality-comparison functions for hashes in
14438c4497 (introduce hasheq() and oideq(), 2018-08-28). A
few topics were in-flight at the time, and can now be
converted. This covers all spots found by "make coccicheck"
in master (the coccicheck results were tweaked by hand for
Signed-off-by: Jeff King <peff@xxxxxxxx>
Jake: I was surprised that this was not a "patch 2" on top of your
earlier coccicheck patch. Apologies if you were planning to send it out.
This doesn't conflict with anything in "pu", so it's a reasonable time
to apply it. There are a few lingering cases in pu, so another option is
to wait a week or two and see if they get merged.
These conversions look good to me!
Reviewed-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx>