Web lists-archives.com

Re: [PATCH 3/5] diff --color-moved-ws: fix a memory leak

On Tue, Oct 2, 2018 at 10:55 AM Phillip Wood <phillip.wood@xxxxxxxxxxxx> wrote:
> From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx>
> Don't duplicate the indentation string if we're not going to use it.
> This was found with asan.

Makes sense,


With compute_ws_delta growing bigger here (and having only one caller),
I wonder if we want to pass 'match' instead of match->es (and pmb_nr),
such that the function can also take care of
    pmb[pmb_nr++].match = match;

Then the function is not a mere compute_ws_delta, but a whole
setup_new_pmb(...) thing. Undecided.