Re: [BUG] Segfault in "git submodule"
- Date: Mon, 1 Oct 2018 12:19:42 -0700
- From: Stefan Beller <sbeller@xxxxxxxxxx>
- Subject: Re: [BUG] Segfault in "git submodule"
On Sat, Sep 29, 2018 at 9:43 AM Raymond Jennings <shentino@xxxxxxxxx> wrote:
> I have a repo, but it appears to be specific to staging area state.
> It only segfaults when I have a certain file deleted.
> Where do you want me to upload it?
> On Sat, Sep 29, 2018 at 8:34 AM Duy Nguyen <pclouds@xxxxxxxxx> wrote:
> > On Sat, Sep 29, 2018 at 5:31 PM Ævar Arnfjörð Bjarmason
> > <avarab@xxxxxxxxx> wrote:
> > > > #1 refs_resolve_ref_unsafe (refs=0x0,
> > > > refname=refname@entry=0x55e863062253 "HEAD",
> > > > resolve_flags=resolve_flags@entry=1, oid=oid@entry=0x7ffdc834b1c0,
> > > > flags=flags@entry=0x7ffdc834b1bc) at refs.c:1493
> > refs is NULL. It looks like somebody fails to get the right submodule
> > ref store (or tries to get it but fails to check if it may return
> > NULL)
This is spot on.
Raymond, are you on Git v2.16.0 by any chance?
(and if now which version are you on).
I suspect 2.16, as that is a version of Git, in which there happens to be
a call into the refs subsystem in submodule--helper.c in line 624.
Is it possible to upgrade Git (to v2.18.0 or later) or cherry-pick
74b6bda32f (submodule: check for NULL return of get_submodule_ref_store(),
2018-03-28) into your copy of Git?