Re: [PATCH] fetch: fix compilation warning
- Date: Sat, 29 Sep 2018 11:34:59 -0700
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH] fetch: fix compilation warning
Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes:
> You probably already know, but I had to add this on top of the 'pu'
> branch to get a clean compile tonight (your 'jc/war-on-string-list'
It was not just about squelching a warning but simply broken code
that deserved to be warned/errored. I think what we have in 'pu'
now is already fixed.
> hashmap_free(&remote_refs, 1);
> - string_list_clear(&remote_refs, 0);
> + string_list_clear(&remote_refs_list, 0);
> static struct ref *get_ref_map(struct remote *remote,