Re: [PATCH] t1400: drop debug `echo` to actually execute `test`
- Date: Sat, 29 Sep 2018 04:00:16 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] t1400: drop debug `echo` to actually execute `test`
On Fri, Sep 28, 2018 at 05:43:59PM +0200, Martin Ågren wrote:
> Instead of running `test "foo" = "$(bar)"`, we prefix the whole thing
> with `echo`. Comparing to nearby tests makes it clear that this is just
> debug leftover. This line has actually been modified four times since it
> was introduced in e52290428b (General ref log reading improvements.,
> 2006-05-19) and the `echo` has always survived. Let's finally drop it.
Hmm, yeah. I cannot see how this echo was ever accomplishing anything.
> This script could need some more cleanups. This is just an immediate fix
> so that we actually test what we intend to.
Yeah, this is definitely worth doing now, and not holding hostage to a
> t/t1400-update-ref.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The patch looks good to me. Thanks!